Code_Reviews_and_Approvals

Code Reviews and Approvals

Best practices for reviewing code.

📊 Review Flow

graph LR
    A[PR Created] --> B[Reviewers Assigned]
    B --> C[Review Changes]
    C --> D{Approve?}
    D -->|Yes| E[Merge]
    D -->|No| F[Request Changes]
    F --> G[Author Updates]
    G --> C

🔧 CLI Review Commands

Request Review

gh pr edit 123 --add-reviewer username

Adds reviewer to PR.

Approve PR

gh pr review 123 --approve

Approves the pull request.

Approve with Comment

gh pr review 123 --approve --body "LGTM!"

Approves with message.

Request Changes

gh pr review 123 --request-changes --body "Please fix the validation logic"

Requests changes before merge.

Comment Only

gh pr review 123 --comment --body "Have you considered..."

Adds comment without approval.

View Review Status

gh pr view 123

Shows review status.

📋 Review Checklist

What to Check

• Code compiles/runs
• Tests pass
• No security issues
• Documentation updated
• No unnecessary complexity
• Follows coding standards

💬 Review Comments

Good Comment Examples

Consider extracting this into a function for reusability.

This might cause N+1 queries. Consider using eager loading.

Nice solution! Much cleaner than the previous approach.

Avoid These

This is wrong.

Why did you do this?

Use constructive language instead.

📁 CODEOWNERS

Create .github/CODEOWNERS:

# Default
* @team-lead

# By path
/src/frontend/ @frontend-team
/src/api/ @backend-team

# By type
*.js @js-experts
*.py @python-team

Auto-assigns reviewers by path.

⚙️ Branch Protection

Require Approvals

Set in repo settings:

• Require 1-2 approving reviews
• Dismiss stale reviews on new commits
• Require review from code owners

💡 Tips

🔗 Related

• Pull Requests
• Branch Protection

#github #review #approval #codereview